| Summary: | Fails to build without glib | ||
|---|---|---|---|
| Product: | poppler | Reporter: | Hib Eris <hib> |
| Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | 0001-Build-gtk-test-only-with-glib-bindings-enabled.patch | ||
|
Description
Hib Eris
2011-03-12 13:27:31 UTC
Doesn't feel the proper fix, can you try
diff --git a/test/Makefile.am b/test/Makefile.am
index a0eb4d0..0252911 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -18,6 +18,9 @@ cairo_includes = \
endif
+gtk_test = \
+ gtk-test
+
endif
if BUILD_SPLASH_OUTPUT
@@ -30,9 +33,6 @@ endif
pdf_fullrewrite = \
pdf-fullrewrite
-gtk_test = \
- gtk-test
-
INCLUDES = \
-I$(top_srcdir) \
-I$(top_srcdir)/poppler \
instead?
(In reply to comment #1) > Doesn't feel the proper fix, can you try > > diff --git a/test/Makefile.am b/test/Makefile.am > index a0eb4d0..0252911 100644 > --- a/test/Makefile.am > +++ b/test/Makefile.am > @@ -18,6 +18,9 @@ cairo_includes = \ > > endif > > +gtk_test = \ > + gtk-test > + > endif > > if BUILD_SPLASH_OUTPUT > @@ -30,9 +33,6 @@ endif > pdf_fullrewrite = \ > pdf-fullrewrite > > -gtk_test = \ > - gtk-test > - > INCLUDES = \ > -I$(top_srcdir) \ > -I$(top_srcdir)/poppler \ > > > instead? Yeah, that is best, please commit! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.