Bug 35258 - Fails to build without glib
Summary: Fails to build without glib
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-12 13:27 UTC by Hib Eris
Modified: 2011-03-13 17:10 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
0001-Build-gtk-test-only-with-glib-bindings-enabled.patch (591 bytes, patch)
2011-03-12 13:27 UTC, Hib Eris 		Details | Splinter Review
View All

Description Hib Eris 2011-03-12 13:27:31 UTC 
Created attachment 44405 [details] [review]
0001-Build-gtk-test-only-with-glib-bindings-enabled.patch

Configuring poppler without the required glib/cairo dependencies or with --disable-glib causes the build to fail.

See patch.
Comment 1 Albert Astals Cid 2011-03-13 05:22:19 UTC 
Doesn't feel the proper fix, can you try

diff --git a/test/Makefile.am b/test/Makefile.am
index a0eb4d0..0252911 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -18,6 +18,9 @@ cairo_includes =                              \
 
 endif
 
+gtk_test = \
+       gtk-test
+
 endif
 
 if BUILD_SPLASH_OUTPUT
@@ -30,9 +33,6 @@ endif
 pdf_fullrewrite = \
        pdf-fullrewrite
 
-gtk_test = \
-       gtk-test
-
 INCLUDES =                                     \
        -I$(top_srcdir)                         \
        -I$(top_srcdir)/poppler                 \


instead?
Comment 2 Hib Eris 2011-03-13 10:01:13 UTC 
(In reply to comment #1)
> Doesn't feel the proper fix, can you try
> 
> diff --git a/test/Makefile.am b/test/Makefile.am
> index a0eb4d0..0252911 100644
> --- a/test/Makefile.am
> +++ b/test/Makefile.am
> @@ -18,6 +18,9 @@ cairo_includes =                              \
> 
>  endif
> 
> +gtk_test = \
> +       gtk-test
> +
>  endif
> 
>  if BUILD_SPLASH_OUTPUT
> @@ -30,9 +33,6 @@ endif
>  pdf_fullrewrite = \
>         pdf-fullrewrite
> 
> -gtk_test = \
> -       gtk-test
> -
>  INCLUDES =                                     \
>         -I$(top_srcdir)                         \
>         -I$(top_srcdir)/poppler                 \
> 
> 
> instead?

Yeah, that is best, please commit!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.