| Summary: | [PATCH] Update Sri Lankan (lk) keymap to use Sinhala keysyms | ||
|---|---|---|---|
| Product: | xkeyboard-config | Reporter: | Harshula Jayasuriya <harshula> |
| Component: | General | Assignee: | xkb |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | CC: | peter.hutterer |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Update lk keymap to use Sinhala keysyms | ||
|
Description
Harshula Jayasuriya
2011-03-21 20:19:41 UTC
Created attachment 44701 [details] [review] Update lk keymap to use Sinhala keysyms patch looks sane to me, but we need to get libX11 and xproto releases out before we can merge this into xkeyboard-config. Sergey, what are your current release schedules? I am going to make special release for GNOME3, in a couple of weeks. Next release is planned in May. Then - September. Please advise when would be the best moment to include that patch? On Tue, Mar 22, 2011 at 01:55:09PM -0700,Sergey V. Udaltsov wrote:
> I am going to make special release for GNOME3, in a couple of weeks. Next
> release is planned in May. Then - September. Please advise when would be the
> best moment to include that patch?
Well, at the moment, we don't have an xproto shipped with these changes,
but we can fix that.
xproto 7.0.21 was just released, so feel free to require that for the sinhala keysyms. I do not specify runtime dependency on xproto. So I will just commit the patch:) The update to lk layout to use keysyms also requires a new version of libX11 to be released. i.e. it needs http://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=25eb76b3d2726f2f1de759901971ae53b2539dc4 If the updated lk layout is released and used by a user before the aforementioned patch is released in a new version of libX11, the lk layout will not work. i.e. It will be a regression. Is there a way we can hold this change back until a new version of libX11 is released? On Wed, Mar 23, 2011 at 06:15:47PM -0700, bugzilla-daemon@freedesktop.org wrote: > Is there a way we can hold this change back until a new version of libX11 is > released? or just put requires into xkeyboard-config. If we require something, we should just state so. It'll certainly save time for distributors and testers having to triage bugs caused by an unmet dependency. Build dependencies are: a) http://cgit.freedesktop.org/xorg/proto/x11proto/commit/?id=423f5faddbb1023d0c1cf55b9d1da4397aa1aa26 in x11proto is needed by libX11 once libX11 has http://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=25eb76b3d2726f2f1de759901971ae53b2539dc4 Runtime dependencies are: b) The updated lk layout needs a libX11 that was built with http://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=25eb76b3d2726f2f1de759901971ae53b2539dc4 I do not see any need in build dependencies. The build won't break if we do not have those keysyms around. How would you propose to check the runtime dependencies? xkbcomp will fail, that's it. Moved this discussion to Bug 35640 to keep this bug clean. Patch attached there too. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.