Bug 35573

Summary:	Call: Method to report misc errors on Content
Product:	Telepathy	Reporter:	Olivier Crête <olivier.crete>
Component:	tp-spec	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	david.laban, sjoerd
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:	Call
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	34189

Description Olivier Crête 2011-03-22 15:55:32 UTC

Right now, telepathy-farstream calls Call.Content.Remove() if there is an error.
We should probably add a method in Call.Content.I.Media instead for that. Maybe something like Error(s: detailed, s: message) or Failed() .. something like the Sending/ReceivingFailed() in the Stream... If you want to see some of the cases, grep for "content_error" in call-content.c in telepathy-farstream.

Then we can remove the reason parameter in C.C.Remove(), since the reason there will always be user-requested.

Comment 1 David Laban 2011-03-31 10:28:41 UTC

I have done a bit of cleanup with regards state change reasons. You can find it at 

http://git.collabora.co.uk/?p=user/alsuren/telepathy-spec.git;a=shortlog;h=refs/heads/remove-reason

I'm not sure what you mean by "something like the Sending/ReceivingFailed() in the Stream". I added an Error() function to Stream.I.Media, but not anything that's specific to either Sending or Receiving, I don't think.

When I fix #34189 (probably using AcceptCandidatePair/RejectCandidatePair, I might add a Reason to Reject too, which could be propagated up, or I might just define an appropriate Reason and error that the CM should create)

Comment 2 David Laban 2011-03-31 10:30:01 UTC

*** Bug 28723 has been marked as a duplicate of this bug. ***

Comment 3 Olivier Crête 2011-03-31 10:38:25 UTC

I can only think of one reason for Reject(): "Codecs don't match", but maybe I'm forgetting something.

Network_Fault -> Network_Error (to match the rest of the spec)

Otherwise looks ++

Comment 4 David Laban 2011-04-04 03:33:13 UTC

Abusing the Assigned status to mean that the fix has been reviewed and merged
into alsuren/call.

I have considered the last two commits of remove-reason to be insta-reviewed.

Comment 5 David Laban 2011-07-19 12:25:39 UTC

Fix merged to master. We ended up having a single "call state change reason" struct, with actor, reason enum, dbus error and debugging message.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.