Bug 36084

Summary: --enable-vfp broken
Product: liboil Reporter: Christophe Lyon <christophe.lyon>
Component: unknownAssignee: David Schleef <ds>
Status: NEW --- QA Contact: David Schleef <ds>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch

Description Christophe Lyon 2011-04-08 09:29:15 UTC 
Hello,

The handling of --enable-vfp configure option is broken as of release 0.3.17.
1- there is a typo "$enable-vfp" instead of "$enable_vfp" which effectively disables proper handling of the option.

2- it should also add -mfpu=vfp to CCASFLAGS, such that the correct fpu flag is passed when 'compiling' the assembly version of math_vfp_asm.S. Indeed, without this flag, recent binutils (such as Code Sourcery 2010.09) complain about some FPU instructions. Another way to achieve that is to add a .fpu vfp directive in that assembly file.

I propose the attached patch.
Comment 1 Christophe Lyon 2011-04-08 09:30:13 UTC 
Created attachment 45427 [details] [review]
Patch

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.