Bug 36084 - --enable-vfp broken
Summary: --enable-vfp broken
Status: NEW
Alias: None
Product: liboil
Classification: Unclassified
Component: unknown (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: David Schleef
QA Contact: David Schleef
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-08 09:29 UTC by Christophe Lyon
Modified: 2011-04-08 09:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch (1.11 KB, patch)
2011-04-08 09:30 UTC, Christophe Lyon
Details | Splinter Review

Description Christophe Lyon 2011-04-08 09:29:15 UTC
Hello,

The handling of --enable-vfp configure option is broken as of release 0.3.17.
1- there is a typo "$enable-vfp" instead of "$enable_vfp" which effectively disables proper handling of the option.

2- it should also add -mfpu=vfp to CCASFLAGS, such that the correct fpu flag is passed when 'compiling' the assembly version of math_vfp_asm.S. Indeed, without this flag, recent binutils (such as Code Sourcery 2010.09) complain about some FPU instructions. Another way to achieve that is to add a .fpu vfp directive in that assembly file.

I propose the attached patch.
Comment 1 Christophe Lyon 2011-04-08 09:30:13 UTC
Created attachment 45427 [details] [review]
Patch


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.