Bug 36130

Summary:	libdbus docs are uploaded with g-w under default umask
Product:	dbus	Reporter:	Simon McVittie <smcv>
Component:	core	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	John (J5) Palmieri <johnp>
Severity:	normal
Priority:	medium	CC:	hp, will
Version:	1.4.x	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	36074
Attachments:	When uploading docs, use rsync -p to set permissions

Description Simon McVittie 2011-04-11 04:27:41 UTC

Created attachment 45473 [details] [review]
When uploading docs, use rsync -p to set permissions

It turns out that rsync --chmod means "pretend the source files had already had this chmod operation applied to them", and not "chmod the destination files" like you'd expect.

As a result, the -p (--perms) option is also needed, so that rsync will "preserve" the modified permissions. Otherwise, the docs will not be group-writeable as intended, and only the person who made the previous upload will be able to upload them next time.

Comment 1 Will Thompson 2011-04-12 03:22:01 UTC

Review of attachment 45473 [details] [review]:

Looks good.

Comment 2 Simon McVittie 2011-04-12 03:27:47 UTC

Thanks, fixed in git for 1.4.10, 1.5.1 (and I fixed the permissions manually for the 1.5.0 upload).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.