Bug 36130 - libdbus docs are uploaded with g-w under default umask
Summary: libdbus docs are uploaded with g-w under default umask
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.4.x
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks: dbus-1.4
  Show dependency tree / graph
 
Reported: 2011-04-11 04:27 UTC by Simon McVittie
Modified: 2011-04-12 03:27 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
When uploading docs, use rsync -p to set permissions (1.25 KB, patch)
2011-04-11 04:27 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2011-04-11 04:27:41 UTC 
Created attachment 45473 [details] [review]
When uploading docs, use rsync -p to set permissions

It turns out that rsync --chmod means "pretend the source files had already had this chmod operation applied to them", and not "chmod the destination files" like you'd expect.

As a result, the -p (--perms) option is also needed, so that rsync will "preserve" the modified permissions. Otherwise, the docs will not be group-writeable as intended, and only the person who made the previous upload will be able to upload them next time.
Comment 1 Will Thompson 2011-04-12 03:22:01 UTC 
Review of attachment 45473 [details] [review]:

Looks good.
Comment 2 Simon McVittie 2011-04-12 03:27:47 UTC 
Thanks, fixed in git for 1.4.10, 1.5.1 (and I fixed the permissions manually for the 1.5.0 upload).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.