| Summary: | Changes to non-parameters from storage backends may not get propagated to CMs | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Vivek Dasmohapatra <vivek> |
| Component: | mission-control | Assignee: | Vivek Dasmohapatra <vivek> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | minor | ||
| Priority: | medium | Keywords: | patch |
| Version: | 5.7 | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.co.uk/git/user/vivek/telepathy-mission-control/log/?h=propagate-backend-prop-changes-to-cm | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
|
Description
Vivek Dasmohapatra
2011-05-04 08:03:43 UTC
I can't help thinking that the whole account-storage API needs a redesign... but this looks a reasonable approach to getting the desired side-effect of changing a property.
One thing that's a bit wrong:
> + if (prop->setprop != NULL)
> + prop->setprop (self, prop->name, &value, NULL);
> +
> + /* now emit our own property changed signal directly */
> mcd_account_changed_property (account, prop->name, &value);
The Set() implementation for every mutable property should be calling mcd_account_changed_property already (e.g. for Nickname this is via mcd_account_set_string_val).
... so you shouldn't need to call mcd_account_changed_property explicitly any more, is what I meant to say. (In reply to comment #2) > ... so you shouldn't need to call mcd_account_changed_property explicitly any > more, is what I meant to say. Amended, rebased, pushed. r+ Released in 5.7.10 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.