Bug 36844 - Changes to non-parameters from storage backends may not get propagated to CMs
Summary: Changes to non-parameters from storage backends may not get propagated to CMs
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: 5.7
Hardware: Other All
: medium minor
Assignee: Vivek Dasmohapatra
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.co.uk/git/user/...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-05-04 08:03 UTC by Vivek Dasmohapatra
Modified: 2011-05-24 11:05 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Vivek Dasmohapatra 2011-05-04 08:03:43 UTC
When a storage backend (such as libaccounts/sso) alters a non-parameter
(such as Nickname), the new value may not get propagated to CMs until 
they restart.
Comment 1 Simon McVittie 2011-05-04 08:25:45 UTC
I can't help thinking that the whole account-storage API needs a redesign... but this looks a reasonable approach to getting the desired side-effect of changing a property.

One thing that's a bit wrong:

> + if (prop->setprop != NULL)
> + prop->setprop (self, prop->name, &value, NULL);
> +
> + /* now emit our own property changed signal directly */
>   mcd_account_changed_property (account, prop->name, &value);

The Set() implementation for every mutable property should be calling mcd_account_changed_property already (e.g. for Nickname this is via mcd_account_set_string_val).
Comment 2 Simon McVittie 2011-05-04 08:26:28 UTC
... so you shouldn't need to call mcd_account_changed_property explicitly any more, is what I meant to say.
Comment 3 Vivek Dasmohapatra 2011-05-04 08:51:40 UTC
(In reply to comment #2)
> ... so you shouldn't need to call mcd_account_changed_property explicitly any
> more, is what I meant to say.

Amended, rebased, pushed.
Comment 4 Simon McVittie 2011-05-06 04:27:49 UTC
r+
Comment 5 Vivek Dasmohapatra 2011-05-24 11:05:35 UTC
Released in 5.7.10


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.