| Summary: | Improve LXDE detection for xdg-open | ||
|---|---|---|---|
| Product: | Portland | Reporter: | snafu <urxmurx> |
| Component: | xdg-utils | Assignee: | Portland Bugs <portland-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | freedesktop.zen.ssokolow |
| Version: | 1.1.0 rc1 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
snafu
2011-05-06 04:49:59 UTC
Perhaps, though I'm curious where XDG_CURRENT_DESKTOP comes from. Is this part of some standard or spec? Concerning where $XDG_CURRENT_DESKTOP comes from, it seems that there is at least some kind of request to add this to the spec (see discussion: http://lists.freedesktop.org/archives/xdg/2011-March/011847.html). As stated there, the LXDE project is already using that variable. I also found a changelog entry for the lxpanel package on https://launchpad.net/ubuntu/+source/lxpanel/0.5.4.1-1, which mentions the use of this variable. So even if it is not "official", it can IMHO be assumed, that LXDE is not going to change its behaviour in the near future. well, I usually would be hesitant (and since it's lxde and other's changing stuff that breaks things here), but in this case I actually do like the intent of XDG_CURRENT_DESKTOP, so ok. Is there any chance that this is getting done? :-)
What about looking into $DESKTOP_SESSION first, and in case that there is nothing in it, which xdg-open is able to handle, one would fallback to $XDG_CURRENT_DESKTOP. This should not arise any negative consequences at all.
BTW: I installed the official Lubuntu release and like Linux Mint it puts its own value ("Lubuntu") into $DESKTOP_SESSION. Though, DE-detection is broken here, too (and perhaps on many other systems either).
I really would appreciate you to implement that functionality.
So, I think this is largely implemented in http://cgit.freedesktop.org/xdg/xdg-utils/commit/?id=3ba869a97b737fd308502a7f9e63bda202891642 for completeness, see current detectDE function in: http://cgit.freedesktop.org/xdg/xdg-utils/tree/scripts/xdg-utils-common.in feel free to re-open or open a new bug if you find any specific failings. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.