Bug 36996

Created attachment 46467 [details]
logs

    * c xmlns='http://jabber.org/protocol/caps' node='http://www.android.com/gtalk/client/caps' ext='pmuc-v1 voice-v1 video-v1 camera-v1' ver='1.1'

I suspect we don't special-case this caps node.

(In reply to comment #2)
>     * c xmlns='http://jabber.org/protocol/caps'
> node='http://www.android.com/gtalk/client/caps' ext='pmuc-v1 voice-v1 video-v1
> camera-v1' ver='1.1'
> 
> I suspect we don't special-case this caps node.

To clarify, see here: http://cgit.freedesktop.org/telepathy/telepathy-gabble/tree/src/presence-cache.c#n474

We special-case these Googley ext='' fields for gmail and gtalk desktop, but not for Android. At least the last time I checked, none of these clients actually answered the disco queries with the relevant capabilities.

So it *should* be okay to throw another line into that macro for Android.

Created attachment 49621 [details] [review]
Fix as proposed by Will

Here is a patch, I tested it against a Nexus S and it seems to work fine, as my Empathy thinks it can call the Nexus S.

Review of attachment 49621 [details] [review]:

Looks fine. I wish Google would fix their disco responses…

(In reply to comment #4)
> Created attachment 49621 [details] [review] [review]
> Fix as proposed by Will
> 
> Here is a patch, I tested it against a Nexus S and it seems to work fine, as my
> Empathy thinks it can call the Nexus S.

Is this one still required and does video calling work with a Nexus S with that ? I'm just looking at 
https://bugs.freedesktop.org/show_bug.cgi?id=36998

Which seems to require another quirk for making video calls work (both needed with ICS tablets and my mothers recently updated Galaxy S II)

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/145.