Bug 36996 - Gabble claims that Nexus S contact does not support AV
Summary: Gabble claims that Nexus S contact does not support AV
Status: NEW
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 02:12 UTC by Guillaume Desmottes
Modified: 2012-06-02 02:49 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
logs (16.13 KB, text/plain)
2011-05-09 02:15 UTC, Guillaume Desmottes
Details
Fix as proposed by Will (1.21 KB, patch)
2011-07-27 09:44 UTC, Olivier Crête
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Desmottes 2011-05-09 02:12:53 UTC
I tried to call a friend having a Nexus S having latest Android (it's supposed to support A/V now) and Gabble (0.11.10) claims he doesn't support audio/video.
Comment 1 Guillaume Desmottes 2011-05-09 02:15:59 UTC
Created attachment 46467 [details]
logs
Comment 2 Will Thompson 2011-06-15 10:17:41 UTC
    * c xmlns='http://jabber.org/protocol/caps' node='http://www.android.com/gtalk/client/caps' ext='pmuc-v1 voice-v1 video-v1 camera-v1' ver='1.1'

I suspect we don't special-case this caps node.
Comment 3 Will Thompson 2011-07-15 10:01:09 UTC
(In reply to comment #2)
>     * c xmlns='http://jabber.org/protocol/caps'
> node='http://www.android.com/gtalk/client/caps' ext='pmuc-v1 voice-v1 video-v1
> camera-v1' ver='1.1'
> 
> I suspect we don't special-case this caps node.

To clarify, see here: http://cgit.freedesktop.org/telepathy/telepathy-gabble/tree/src/presence-cache.c#n474

We special-case these Googley ext='' fields for gmail and gtalk desktop, but not for Android. At least the last time I checked, none of these clients actually answered the disco queries with the relevant capabilities.

So it *should* be okay to throw another line into that macro for Android.
Comment 4 Olivier Crête 2011-07-27 09:44:04 UTC
Created attachment 49621 [details] [review]
Fix as proposed by Will

Here is a patch, I tested it against a Nexus S and it seems to work fine, as my Empathy thinks it can call the Nexus S.
Comment 5 Will Thompson 2011-07-27 10:38:32 UTC
Review of attachment 49621 [details] [review]:

Looks fine. I wish Google would fix their disco responses…
Comment 6 Sjoerd Simons 2012-06-02 02:49:16 UTC
(In reply to comment #4)
> Created attachment 49621 [details] [review] [review]
> Fix as proposed by Will
> 
> Here is a patch, I tested it against a Nexus S and it seems to work fine, as my
> Empathy thinks it can call the Nexus S.

Is this one still required and does video calling work with a Nexus S with that ? I'm just looking at 
https://bugs.freedesktop.org/show_bug.cgi?id=36998

Which seems to require another quirk for making video calls work (both needed with ICS tablets and my mothers recently updated Galaxy S II)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.