Bug 37049

(In reply to comment #0)
> the desc.flags is using the DSDESC_PIXELFORMAT (a surface descritption flag)
> instead of "DWDESC_PIXELFORMAT".

It looks correct to me, because they are flags of a IDirectFBSurface, not of a IDirectFBWindow:
http://directfb.org/docs/DirectFB_Reference_1_5/types.html#DFBSurfaceDescriptionFlags

> attached is a patch fixing it.

You forgot the attachment.

Please check again and, if the bug really exists, reopen with the attachment.
Thank you!

Created attachment 46520 [details] [review]
Fix the desc.flags when creating a DirectFB window

(In reply to comment #2)
> Created an attachment (id=46520) [details]
> Fix the desc.flags when creating a DirectFB window

I also removed:
desc.caps  = DSCAPS_NONE;

because the "desc.caps" filed won't be taken into account unless the flags "DWDESC_CAPS" is specified in the "desc.flags".

regards.
Haithem.

(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=46520) [details] [details]
> > Fix the desc.flags when creating a DirectFB window
> 
> I also removed:
> desc.caps  = DSCAPS_NONE;
> 
> because the "desc.caps" filed won't be taken into account unless the flags
> "DWDESC_CAPS" is specified in the "desc.flags".
> 
> regards.
> Haithem.

Fixed in:

commit 8fb9a6727e2b769bfa388c6027ebad0a53ffa02b
Author: Haithem Rahmani <haithem.rahmani@gmail.com>
Date:   Mon Jun 20 11:16:14 2011 +0200

    boilerplate: Use correct flag type in DFBWindowDescription
    
    The window description flag macros are prefixed with DWDESC_.
    
    The issue was not noticed because DWDESC_CAPS and DSDESC_CAPS have the
    same value.
    
    Fixes https://bugs.freedesktop.org/show_bug.cgi?id=37049


I left the .caps alone, as they are or'ed later.
Thank you for your patch!