Bug 37049 - a small type in the "desc.flags" when creating a wnidow.
Summary: a small type in the "desc.flags" when creating a wnidow.
Status: RESOLVED FIXED
Alias: None
Product: cairo
Classification: Unclassified
Component: directfb backend (show other bugs)
Version: 1.10.2
Hardware: Other All
: medium normal
Assignee: cairo-bugs mailing list
QA Contact: cairo-bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 23:34 UTC by haithem
Modified: 2011-06-20 03:08 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Fix the desc.flags when creating a DirectFB window (764 bytes, patch)
2011-05-10 01:20 UTC, haithem
Details | Splinter Review

Description haithem 2011-05-09 23:34:31 UTC
the desc.flags is using the DSDESC_PIXELFORMAT (a surface descritption flag)
instead of "DWDESC_PIXELFORMAT".
attached is a patch fixing it.
Comment 1 Andrea Canciani 2011-05-09 23:56:34 UTC
(In reply to comment #0)
> the desc.flags is using the DSDESC_PIXELFORMAT (a surface descritption flag)
> instead of "DWDESC_PIXELFORMAT".

It looks correct to me, because they are flags of a IDirectFBSurface, not of a IDirectFBWindow:
http://directfb.org/docs/DirectFB_Reference_1_5/types.html#DFBSurfaceDescriptionFlags

> attached is a patch fixing it.

You forgot the attachment.

Please check again and, if the bug really exists, reopen with the attachment.
Thank you!
Comment 2 haithem 2011-05-10 01:20:52 UTC
Created attachment 46520 [details] [review]
Fix the desc.flags when creating a DirectFB window
Comment 3 haithem 2011-05-10 01:23:10 UTC
(In reply to comment #2)
> Created an attachment (id=46520) [details]
> Fix the desc.flags when creating a DirectFB window

I also removed:
desc.caps  = DSCAPS_NONE;

because the "desc.caps" filed won't be taken into account unless the flags "DWDESC_CAPS" is specified in the "desc.flags".

regards.
Haithem.
Comment 4 Andrea Canciani 2011-06-20 03:08:30 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=46520) [details] [details]
> > Fix the desc.flags when creating a DirectFB window
> 
> I also removed:
> desc.caps  = DSCAPS_NONE;
> 
> because the "desc.caps" filed won't be taken into account unless the flags
> "DWDESC_CAPS" is specified in the "desc.flags".
> 
> regards.
> Haithem.

Fixed in:

commit 8fb9a6727e2b769bfa388c6027ebad0a53ffa02b
Author: Haithem Rahmani <haithem.rahmani@gmail.com>
Date:   Mon Jun 20 11:16:14 2011 +0200

    boilerplate: Use correct flag type in DFBWindowDescription
    
    The window description flag macros are prefixed with DWDESC_.
    
    The issue was not noticed because DWDESC_CAPS and DSDESC_CAPS have the
    same value.
    
    Fixes https://bugs.freedesktop.org/show_bug.cgi?id=37049


I left the .caps alone, as they are or'ed later.
Thank you for your patch!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.