Bug 37280

Summary:	tp_channel_dispatch_operation_claim_with_async should prepare CDO before calling Claim
Product:	Telepathy	Reporter:	Guillaume Desmottes <guillaume.desmottes>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	simple-channel-dispatch-operation: fire Finished when Claim is called Fix race in tp_channel_dispatch_operation_claim_with_async()

Description Guillaume Desmottes 2011-05-17 03:20:42 UTC

There is a race in tp_channel_dispatch_operation_claim_with_async() : we call Claim() then try to prepare the CDO but Claim() will destroy the CDO and so we can't prepare it.

Comment 1 Guillaume Desmottes 2011-05-17 03:35:20 UTC

Created attachment 46798 [details] [review]
simple-channel-dispatch-operation: fire Finished when Claim is called

Comment 2 Guillaume Desmottes 2011-05-17 03:35:23 UTC

Created attachment 46799 [details] [review]
Fix race in tp_channel_dispatch_operation_claim_with_async()

Claiming the CDO will result in MC destroying it, so we have to prepare it
before calling Claim(). (fdo #37280)

Comment 3 Guillaume Desmottes 2011-05-17 03:40:28 UTC

Reviewed by Jonny on IRC. Merged, will be in 0.15.1.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.