Bug 37280 - tp_channel_dispatch_operation_claim_with_async should prepare CDO before calling Claim
Summary: tp_channel_dispatch_operation_claim_with_async should prepare CDO before call...
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-17 03:20 UTC by Guillaume Desmottes
Modified: 2011-05-17 03:40 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
simple-channel-dispatch-operation: fire Finished when Claim is called (879 bytes, patch)
2011-05-17 03:35 UTC, Guillaume Desmottes 		Details | Splinter Review
Fix race in tp_channel_dispatch_operation_claim_with_async() (4.47 KB, patch)
2011-05-17 03:35 UTC, Guillaume Desmottes 		Details | Splinter Review
View All

Description Guillaume Desmottes 2011-05-17 03:20:42 UTC 
There is a race in tp_channel_dispatch_operation_claim_with_async() : we call Claim() then try to prepare the CDO but Claim() will destroy the CDO and so we can't prepare it.
Comment 1 Guillaume Desmottes 2011-05-17 03:35:20 UTC 
Created attachment 46798 [details] [review]
simple-channel-dispatch-operation: fire Finished when Claim is called
Comment 2 Guillaume Desmottes 2011-05-17 03:35:23 UTC 
Created attachment 46799 [details] [review]
Fix race in tp_channel_dispatch_operation_claim_with_async()

Claiming the CDO will result in MC destroying it, so we have to prepare it
before calling Claim(). (fdo #37280)
Comment 3 Guillaume Desmottes 2011-05-17 03:40:28 UTC 
Reviewed by Jonny on IRC. Merged, will be in 0.15.1.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.