| Summary: | ChannelDispatcher.Interface.Messages.DRAFT is not in the spec | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Vivek Dasmohapatra <vivek> |
| Component: | tp-spec | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 23148, 69600, 70382 | ||
| Attachments: |
[spec master] Import ChannelDispatcher.I.Messages from Mission Control master
[spec master] Complete CD.I.Messages1 [MC master] Undraft CD.I.Messages1 [MC master] Remove unused constants [MC master] Add CD.I.Messages1 to Interfaces |
||
|
Description
Vivek Dasmohapatra
2011-05-19 10:24:23 UTC
None of the arguments have any documentation. + <arg direction="in" name="Flags" type="u"/> This is missing a tp:type. + <arg direction="out" name="Token" type="s"/> So is this. +<node name="/Channel_Dispatcher_Interface_Messages_Draft" I'd rather not have "draft" in the node name or file name. Created attachment 87466 [details] [review] [spec master] Import ChannelDispatcher.I.Messages from Mission Control master My main concern about this interface was whether implementing it caused MC to be unmaintainable, but it isn't too bad in practice, just unfinished. The one edit here, relative to Mission Control, is making the filename end with "1.xml" instead of "_DRAFT.xml", so that subsequent diffs on the contents aren't lost in the rename noise. Created attachment 87467 [details] [review] [spec master] Complete CD.I.Messages1 Created attachment 87468 [details] [review] [MC master] Undraft CD.I.Messages1 --- This assumes that the patches above have been merged into telepathy-spec, and that we've done the spec -> release -> telepathy-glib -> release dance. Someone should teach telepathy-qt about the new name for this interface, too. Created attachment 87469 [details] [review] [MC master] Remove unused constants --- Left over from some sort of ACL arrangement, I think. Created attachment 87470 [details] [review] [MC master] Add CD.I.Messages1 to Interfaces --- Nice to see that the implementation was of such high quality. :-) Alternatively, if people don't like this interface, we can leave it in master in its current broken/draft form (because telepathy-qt uses it already...), and delete it from 1.0. Comment on attachment 87466 [details] [review] [spec master] Import ChannelDispatcher.I.Messages from Mission Control master Review of attachment 87466 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 87467 [details] [review] [spec master] Complete CD.I.Messages1 Review of attachment 87467 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 87468 [details] [review] [MC master] Undraft CD.I.Messages1 Review of attachment 87468 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 87469 [details] [review] [MC master] Remove unused constants Review of attachment 87469 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 87470 [details] [review] [MC master] Add CD.I.Messages1 to Interfaces Review of attachment 87470 [details] [review]: ----------------------------------------------------------------- ++ Merged to spec master. Still to do: release it in spec 0.27.3, release it in telepathy-glib 0.23.0 and merge those patches to MC. Finally fixed in git for MC 5.17 \o/ |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.