| Summary: | Accounts with no 'conditions' set would treat no-connected-transports as 'connected' | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Vivek Dasmohapatra <vivek> |
| Component: | mission-control | Assignee: | Vivek Dasmohapatra <vivek> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | minor | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/vivek/telepathy-mission-control/log/?h=unconditional-accounts-skip-too-many-transport-checks | ||
| Whiteboard: | NB#259026, NB#262409 | ||
| i915 platform: | i915 features: | ||
|
Description
Vivek Dasmohapatra
2011-06-01 05:58:40 UTC
This regresses support for connections which genuinely don't need an Internet connection, like the cellular connection in telepathy-ring; that function should still short-circuit for such connections. (Longer-term - in 5.9? - we need to discard McdTransport entirely, and add a connectivity plugin API using mission-control-plugins that doesn't distribute the logic more or less randomly between MC and the plugin.) (In reply to comment #1) > This regresses support for connections which genuinely don't need an Internet Regression fixed in latest commit. Aaand now we handle the "no transport plugins" case too. > + unconditional = n_conds == 0;
Parentheses for clarity, please. Other than that, this looks OK; I assume tests now pass?
> Parentheses for clarity, please. Other than that, this looks OK; I assume tests
> now pass?
Amended, and yes.
Released in 5.8.0 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.