Bug 37813 - Accounts with no 'conditions' set would treat no-connected-transports as 'connected'
Summary: Accounts with no 'conditions' set would treat no-connected-transports as 'con...
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: git master
Hardware: Other All
: medium minor
Assignee: Vivek Dasmohapatra
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/vi...
Whiteboard: NB#259026, NB#262409
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-06-01 05:58 UTC by Vivek Dasmohapatra
Modified: 2011-09-06 07:10 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Vivek Dasmohapatra 2011-06-01 05:58:40 UTC
_mcd_master_account_replace_transport would accept 
"no connection" as a successful replacement if no 
account conditions were specified, triggering unwanted
reconnections.
Comment 1 Simon McVittie 2011-06-03 03:21:54 UTC
This regresses support for connections which genuinely don't need an Internet connection, like the cellular connection in telepathy-ring; that function should still short-circuit for such connections.

(Longer-term - in 5.9? - we need to discard McdTransport entirely, and add a connectivity plugin API using mission-control-plugins that doesn't distribute the logic more or less randomly between MC and the plugin.)
Comment 2 Vivek Dasmohapatra 2011-06-08 10:32:57 UTC
(In reply to comment #1)
> This regresses support for connections which genuinely don't need an Internet

Regression fixed in latest commit.
Comment 3 Vivek Dasmohapatra 2011-07-20 09:39:45 UTC
Aaand now we handle the "no transport plugins" case too.
Comment 4 Simon McVittie 2011-07-20 10:25:45 UTC
> + unconditional = n_conds == 0;

Parentheses for clarity, please. Other than that, this looks OK; I assume tests now pass?
Comment 5 Vivek Dasmohapatra 2011-07-20 10:37:44 UTC
> Parentheses for clarity, please. Other than that, this looks OK; I assume tests
> now pass?

Amended, and yes.
Comment 6 Vivek Dasmohapatra 2011-09-06 07:10:20 UTC
Released in 5.8.0


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.