Bug 38001

Summary:	QNX poll issue
Product:	XCB	Reporter:	seanb
Component:	Library	Assignee:	xcb mailing list dummy <xcb>
Status:	RESOLVED FIXED	QA Contact:	xcb mailing list dummy <xcb>
Severity:	normal
Priority:	medium	CC:	daphnediane
Version:	unspecified
Hardware:	x86 (IA32)
OS:	other
Whiteboard:
i915 platform:		i915 features:
Attachments:	suggested diff git patch based on seanb's diff

Description seanb 2011-06-06 10:50:05 UTC

Created attachment 47618 [details] [review]
suggested diff

On QNX:

# grep POLLIN /usr/include/poll.h
#define POLLIN          (POLLRDNORM | POLLRDBAND)

On exit from the poll loop in _xcb_conn_wait()
only POLLRDNORM is set and the current test
for input doesn't succeed.  Attached is a
diff that I believe is safe on all platforms.

Comment 1 Julien Cristau 2011-06-06 11:38:27 UTC

Review of attachment 47618 [details] [review]:

Looks reasonable.
Acked-by: Julien Cristau <jcristau@debian.org>

Comment 2 Daphne Pfister 2013-09-08 02:33:09 UTC

Any reason this patch hasn't been applied yet?

I'm seeing the same problem on other OSes such as HP-UX that also define POLLIN to be (POLLRDNORM | POLLRDBAND). Patch seems to work for those systems as well.

Comment 3 Daphne Pfister 2013-09-08 20:28:20 UTC

Created attachment 85452 [details] [review]
git patch based on seanb's diff

Comment 4 Uli Schlachter 2013-09-08 21:05:51 UTC

Pushed as commit f1405d9fe4a6ddcae24585ba254389a4c4f4c8c9

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.