Bug 38001 - QNX poll issue
Summary: QNX poll issue
Status: RESOLVED FIXED
Alias: None
Product: XCB
Classification: Unclassified
Component: Library (show other bugs)
Version: unspecified
Hardware: x86 (IA32) other
: medium normal
Assignee: xcb mailing list dummy
QA Contact: xcb mailing list dummy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-06 10:50 UTC by seanb
Modified: 2013-09-08 21:05 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
suggested diff (585 bytes, patch)
2011-06-06 10:50 UTC, seanb
Details | Splinter Review
git patch based on seanb's diff (1019 bytes, patch)
2013-09-08 20:28 UTC, Daphne Pfister
Details | Splinter Review

Description seanb 2011-06-06 10:50:05 UTC
Created attachment 47618 [details] [review]
suggested diff

On QNX:

# grep POLLIN /usr/include/poll.h
#define POLLIN          (POLLRDNORM | POLLRDBAND)

On exit from the poll loop in _xcb_conn_wait()
only POLLRDNORM is set and the current test
for input doesn't succeed.  Attached is a
diff that I believe is safe on all platforms.
Comment 1 Julien Cristau 2011-06-06 11:38:27 UTC
Review of attachment 47618 [details] [review]:

Looks reasonable.
Acked-by: Julien Cristau <jcristau@debian.org>
Comment 2 Daphne Pfister 2013-09-08 02:33:09 UTC
Any reason this patch hasn't been applied yet?

I'm seeing the same problem on other OSes such as HP-UX that also define POLLIN to be (POLLRDNORM | POLLRDBAND). Patch seems to work for those systems as well.
Comment 3 Daphne Pfister 2013-09-08 20:28:20 UTC
Created attachment 85452 [details] [review]
git patch based on seanb's diff
Comment 4 Uli Schlachter 2013-09-08 21:05:51 UTC
Pushed as commit f1405d9fe4a6ddcae24585ba254389a4c4f4c8c9


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.