| Summary: | TpChannelRequest: add API for properties | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=channel-request-props-38605 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | TpChannelRequest: add properties and accessors for Account, UserActionTime and PreferredHandler (#38605) | ||
|
Description
Guillaume Desmottes
2011-06-23 06:13:52 UTC
http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=channel-request-props-38605 This block bug #38249 as I use some of these API in my implementation. Created attachment 48370 [details] [review] TpChannelRequest: add properties and accessors for Account, UserActionTime and PreferredHandler (#38605) I didn't add Requests as it's less useful and I'm not sure we want to expose more string -> GVariant hash table in the API. Review of attachment 48370 [details] [review]: Looks good. One question... ::: telepathy-glib/channel-request.c @@ +687,3 @@ +tp_channel_request_get_user_action_time (TpChannelRequest *self) +{ + if (path == NULL) Is -1 correct here? Perhaps it should be 0 or maxint64. Oh you're right; I meant to change it to 0 and forgot. Fixed and merged to master; will be in 0.15.3. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.