Bug 38605 - TpChannelRequest: add API for properties
Summary: TpChannelRequest: add API for properties
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/ca...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-06-23 06:13 UTC by Guillaume Desmottes
Modified: 2011-06-24 05:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
TpChannelRequest: add properties and accessors for Account, UserActionTime and PreferredHandler (#38605) (9.86 KB, patch)
2011-06-24 01:06 UTC, Guillaume Desmottes 		Details | Splinter Review
View All

Comment 1 Guillaume Desmottes 2011-06-24 01:06:19 UTC 
http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=channel-request-props-38605

This block bug #38249 as I use some of these API in my implementation.
Comment 2 Guillaume Desmottes 2011-06-24 01:06:37 UTC 
Created attachment 48370 [details] [review]
TpChannelRequest: add properties and accessors for Account, UserActionTime and PreferredHandler (#38605)

I didn't add Requests as it's less useful and I'm not sure we want to expose
more string -> GVariant hash table in the API.
Comment 3 Danielle Madeley 2011-06-24 02:24:04 UTC 
Review of attachment 48370 [details] [review]:

Looks good. One question...

::: telepathy-glib/channel-request.c
@@ +687,3 @@
+tp_channel_request_get_user_action_time (TpChannelRequest *self)
+{
+  if (path == NULL)

Is -1 correct here? Perhaps it should be 0 or maxint64.
Comment 4 Guillaume Desmottes 2011-06-24 03:25:43 UTC 
Oh you're right; I meant to change it to 0 and forgot.  Fixed and merged to master; will be in 0.15.3.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.