Bug 38611

Summary: state_tracker/st_format.c:559:st_pipe_format_to_mesa_format: Assertion `0' failed.
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Mesa coreAssignee: Stephane Marchesin <marchesin>
Status: CLOSED DUPLICATE QA Contact:
Severity: critical    
Priority: medium CC: brianp
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2011-06-23 10:23:25 UTC 
mesa: 1e5cef96d184b00eb588b48ecd02386998077d82

Run glean pixelFormats test on softpipe or llvmpipe.

$ ./bin/glean -r results -t pixelFormats --quick
state_tracker/st_format.c:559:st_pipe_format_to_mesa_format: Assertion `0' failed.

(gdb) bt
#0  0x003f3810 in _debug_assert_fail (expr=0x47b00b "0", file=0x47afe1 "state_tracker/st_format.c", line=559, function=0x47dc2f "st_pipe_format_to_mesa_format") at util/u_debug.c:282
#1  0x0026734d in st_pipe_format_to_mesa_format (format=PIPE_FORMAT_R8G8B8X8_UNORM) at state_tracker/st_format.c:559
#2  0x0026776b in st_ChooseTextureFormat_renderable (ctx=0x9d0bfe0, internalFormat=3, format=6408, type=5121, renderable=1 '\001') at state_tracker/st_format.c:1317
#3  0x002677f3 in st_ChooseTextureFormat (ctx=0x9d0bfe0, internalFormat=3, format=6408, type=5121) at state_tracker/st_format.c:1334
#4  0x002421f7 in _mesa_choose_texture_format (ctx=0x9d0bfe0, texObj=0x9d31fa0, target=3553, level=0, internalFormat=3, format=6408, type=5121) at main/teximage.c:2366
#5  0x002426a6 in teximage (ctx=0x9d0bfe0, dims=2, target=3553, level=0, internalFormat=3, width=16, height=16, depth=1, border=0, format=6408, type=5121, pixels=0x9dc7db0) at main/teximage.c:2467
#6  0x00242aa7 in _mesa_TexImage2D (target=3553, level=0, internalFormat=3, width=16, height=16, border=0, format=6408, type=5121, pixels=0x9dc7db0) at main/teximage.c:2540
#7  0x08107a66 in GLEAN::PixelFormatsTest::DrawImage(int, int, unsigned int, unsigned int, int, unsigned char const*) const ()
#8  0x081092ec in GLEAN::PixelFormatsTest::TestCombination(unsigned int, unsigned int, int) ()
#9  0x081096d9 in GLEAN::PixelFormatsTest::runOne(GLEAN::MultiTestResult&, GLEAN::Window&) ()
#10 0x080c5a1e in GLEAN::BaseTest<GLEAN::MultiTestResult>::run(GLEAN::Environment&) ()
#11 0x080bdd46 in main ()
(gdb) frame 1
#1  0x0026734d in st_pipe_format_to_mesa_format (format=PIPE_FORMAT_R8G8B8X8_UNORM) at state_tracker/st_format.c:559
559	      assert(0);
Comment 1 Vinson Lee 2011-06-23 10:39:44 UTC 
1a339b6c71ebab6e1a64f05b2e133022d3bbcd15 is the first bad commit
commit 1a339b6c71ebab6e1a64f05b2e133022d3bbcd15
Author: Stéphane Marchesin <marcheu@chromium.org>
Date:   Wed Jun 22 17:02:21 2011 -0700

    st/mesa: prefer native texture formats when possible.
    
    If possible, we want to match the hardware format to what the app uses. By
    doing so, we avoid the need for pixel conversions and therefore greatly speed
    up texture uploads.

:040000 040000 6f6f68f2559303df0e7041dc1190cd1587557753 a353f28889dc64549acc3933edc12082e5d21a5a M	src
bisect run success
Comment 2 Brian Paul 2011-06-23 15:08:22 UTC 

*** This bug has been marked as a duplicate of bug 38602 ***
Comment 3 Vinson Lee 2011-06-23 16:41:43 UTC 
mesa: 9c5d15e929f47f517f90977f5420e11dfbd3db67 (master)

Verified fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.