Bug 39448

Created attachment 49390 [details] [review]
Second patch, add debug traces

As any log-store, this cannot go in without proper unit tests.

Review of attachment 49389 [details] [review]:

Didn't look at the actual code yet (coming soon), but I noticed many coding style errors, TP logger should be following Telepathy coding style http://telepathy.freedesktop.org/wiki/Style.

::: configure.ac
@@ -157,0 +157,12 @@
+# -----------------------------------------------------------
+# Tracker optional support
+# -----------------------------------------------------------
... 9 more ...

All this should be configurable using --with-tracker= [auto/yes/no, default auto] where using yes would make it fail if tracker dependency is not met, and no would simply disable it without checking dependency.

::: telepathy-logger/Makefile.am
@@ -130,1 +138,5 @@
 TelepathyLogger_0_2_gir_INCLUDES = GObject-2.0 TelepathyGLib-0.12
+
+if HAVE_TRACKER_MINER
+TelepathyLogger_0_2_gir_INCLUDES += TrackerMiner-0.11
+endif

Move the if HAVE... block to the end.

::: telepathy-logger/log-store-factory.c
@@ -50,2 +50,3 @@
   key = g_strdup (logstore_type);
 
+  g_print (">>>> %s\n", logstore_type);

To be removed.

Any interest into fixing the initial issues mention in the quick first step review ?

I did have a go at this quite some time ago, but found some odd interactions wrt the test mode and communication with tracker-store. I'll try to rescue and continue on those patches at some point.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-logger/issues/22.