Bug 39448 - [RFE, PATCH] Add Tracker based TplLogStore
Summary: [RFE, PATCH] Add Tracker based TplLogStore
Status: NEEDINFO
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-21 08:49 UTC by Carlos Garnacho Parro
Modified: 2012-04-06 08:51 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Implement Tracker log store (55.30 KB, patch)
2011-07-21 08:49 UTC, Carlos Garnacho Parro
Details | Splinter Review
Second patch, add debug traces (4.70 KB, patch)
2011-07-21 08:51 UTC, Carlos Garnacho Parro
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garnacho Parro 2011-07-21 08:49:39 UTC
Created attachment 49389 [details] [review]
Implement Tracker log store

I'm attaching a patch that adds a Tracker based TplLogStore, so every information about accounts/contacts/conversations/calls are query-able through sparql. This TplLogStore would only get compiled if Tracker libraries are found.
Comment 1 Carlos Garnacho Parro 2011-07-21 08:51:00 UTC
Created attachment 49390 [details] [review]
Second patch, add debug traces
Comment 2 Nicolas Dufresne 2011-07-22 13:52:12 UTC
As any log-store, this cannot go in without proper unit tests.
Comment 3 Nicolas Dufresne 2011-07-22 14:41:12 UTC
Review of attachment 49389 [details] [review]:

Didn't look at the actual code yet (coming soon), but I noticed many coding style errors, TP logger should be following Telepathy coding style http://telepathy.freedesktop.org/wiki/Style.

::: configure.ac
@@ -157,0 +157,12 @@
+# -----------------------------------------------------------
+# Tracker optional support
+# -----------------------------------------------------------
... 9 more ...

All this should be configurable using --with-tracker= [auto/yes/no, default auto] where using yes would make it fail if tracker dependency is not met, and no would simply disable it without checking dependency.

::: telepathy-logger/Makefile.am
@@ -130,1 +138,5 @@
 TelepathyLogger_0_2_gir_INCLUDES = GObject-2.0 TelepathyGLib-0.12
+
+if HAVE_TRACKER_MINER
+TelepathyLogger_0_2_gir_INCLUDES += TrackerMiner-0.11
+endif

Move the if HAVE... block to the end.

::: telepathy-logger/log-store-factory.c
@@ -50,2 +50,3 @@
   key = g_strdup (logstore_type);
 
+  g_print (">>>> %s\n", logstore_type);

To be removed.
Comment 4 Nicolas Dufresne 2012-04-04 12:18:44 UTC
Any interest into fixing the initial issues mention in the quick first step review ?
Comment 5 Carlos Garnacho Parro 2012-04-06 08:51:19 UTC
I did have a go at this quite some time ago, but found some odd interactions wrt the test mode and communication with tracker-store. I'll try to rescue and continue on those patches at some point.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.