Bug 39630

Summary: MUC: don't rely on message id=''s for delivery reports
Product: Telepathy Reporter: Will Thompson <will>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED MOVED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: git master   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Will Thompson 2011-07-28 09:32:34 UTC 
M-Link, as used by jabber.org, does not include the id='' you set on messages sent to a MUC on the echoes it sends back.

David Cridland sez: “The ids last, in my opinion, as long as the rest of the "header" - the from/to etc. [...] M-Link will in some cases [modify the message body,] which is another argument against repeating the id blindly.”

A bunch of people disagree with him; I'm not sure whether I agree or not. But we could potentially deal with this by having Gabble keep a list of pending messages and matching up messages from ourself against them. (This does not work if you're joined to the same MUC twice using the same MUC JID, which I believe is possible …)

M-Link leaves the id='' intact if it's sending back a <message type='error'/>, so we can continue to rely on this for failure reports in any case.
Comment 1 Will Thompson 2011-07-29 01:35:28 UTC 
The symptom here, by the way, is that Empathy 3.1.x's “messages are being sent” spinner spins forever.
Comment 2 GitLab Migration User 2019-12-03 19:53:35 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/172.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.