Bug 39630 - MUC: don't rely on message id=''s for delivery reports
Summary: MUC: don't rely on message id=''s for delivery reports
Status: NEW
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-28 09:32 UTC by Will Thompson
Modified: 2011-07-29 01:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Will Thompson 2011-07-28 09:32:34 UTC
M-Link, as used by jabber.org, does not include the id='' you set on messages sent to a MUC on the echoes it sends back.

David Cridland sez: “The ids last, in my opinion, as long as the rest of the "header" - the from/to etc. [...] M-Link will in some cases [modify the message body,] which is another argument against repeating the id blindly.”

A bunch of people disagree with him; I'm not sure whether I agree or not. But we could potentially deal with this by having Gabble keep a list of pending messages and matching up messages from ourself against them. (This does not work if you're joined to the same MUC twice using the same MUC JID, which I believe is possible …)

M-Link leaves the id='' intact if it's sending back a <message type='error'/>, so we can continue to rely on this for failure reports in any case.
Comment 1 Will Thompson 2011-07-29 01:35:28 UTC
The symptom here, by the way, is that Empathy 3.1.x's “messages are being sent” spinner spins forever.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.