Bug 40655

Summary:	ChannelDispatchOperation::claim() cannot be used by Approvers to handle channels
Product:	Telepathy	Reporter:	Andre Moreira Magalhaes <andrunko>
Component:	tp-qt	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	ollisal
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Andre Moreira Magalhaes 2011-09-06 10:31:46 UTC

Currently ChannelDispatchOperation::claim() only calls CD.Claim() and do not update the HandledChannels properly indicating that the channels are being handled.

Solution 1:
 - include a CD::claim(handler) that will call CD.Claim() and update the HandledChannels property correctly, and update the current claim() method docs to indicate it should be used only for approvers wishing to close the channels (not handle them). 

Solution 2:
 - change the current claim() method to create a internal handler with an empty filter and keep it around till the channels are closed and update HandledChannels accordingly.

Solution 3:
 - A mix of both or ???

Comment 1 Olli Salli 2011-09-06 10:38:54 UTC

Also affects Observers wishing to Claim

Comment 2 Andre Moreira Magalhaes 2011-09-06 10:41:31 UTC

Just to keep track, there is a non-working WIP branch at http://cgit.collabora.com/git/user/andrunko/telepathy-qt4.git/log/?h=cd-claim

Comment 3 Olli Salli 2011-10-07 07:09:39 UTC

According to the changelog, this was fixed in 0.7.3.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.