Bug 40655 - ChannelDispatchOperation::claim() cannot be used by Approvers to handle channels
Summary: ChannelDispatchOperation::claim() cannot be used by Approvers to handle channels
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-06 10:31 UTC by Andre Moreira Magalhaes
Modified: 2011-10-07 07:09 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Andre Moreira Magalhaes 2011-09-06 10:31:46 UTC
Currently ChannelDispatchOperation::claim() only calls CD.Claim() and do not update the HandledChannels properly indicating that the channels are being handled.

Solution 1:
 - include a CD::claim(handler) that will call CD.Claim() and update the HandledChannels property correctly, and update the current claim() method docs to indicate it should be used only for approvers wishing to close the channels (not handle them). 

Solution 2:
 - change the current claim() method to create a internal handler with an empty filter and keep it around till the channels are closed and update HandledChannels accordingly.

Solution 3:
 - A mix of both or ???
Comment 1 Olli Salli 2011-09-06 10:38:54 UTC
Also affects Observers wishing to Claim
Comment 2 Andre Moreira Magalhaes 2011-09-06 10:41:31 UTC
Just to keep track, there is a non-working WIP branch at http://cgit.collabora.com/git/user/andrunko/telepathy-qt4.git/log/?h=cd-claim
Comment 3 Olli Salli 2011-10-07 07:09:39 UTC
According to the changelog, this was fixed in 0.7.3.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.