Bug 4077

Summary: hw/xfree86/common/{xf86Config.c,xf86Events.c,...}: missing includes
Product: xorg Reporter: Diego Elio Pettenò <flameeyes>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: high CC: dberkholz
Version: unspecified   
Hardware: Other   
OS: FreeBSD   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 4429    
Attachments:
Description Flags
xorg-server-hw-xfree86-common-includes.patch none

Description Diego Elio Pettenò 2005-08-14 08:39:55 UTC 
A few files in hw/xfree86/common/ misses system includes on FreeBSD (probably   
GLIBC is not affected including most of them implicitely). 
 
The attached patch (made from little patches, hope it works out of the box)  
fixes these problems.
Comment 1 Diego Elio Pettenò 2005-08-14 08:40:38 UTC 
Created attachment 3345 [details] [review]
diff-with-cvs-head.patch
Comment 2 Diego Elio Pettenò 2005-08-17 09:44:56 UTC 
Created attachment 2909 [details] [review]
xorg-server-hw-xfree86-common-includes.patch
Comment 3 Adam Jackson 2005-09-09 16:03:51 UTC 
please explain why gentoo/freebsd needs these, since plain freebsd clearly works
already.
Comment 4 Diego Elio Pettenò 2005-09-09 16:13:28 UTC 
The LIBC is the same, so if FreeBSD is using patches or there's something in 
autotools that bypass some of imake tests, Gentoo/FreeBSD hit the problem. 
 
They are needed on a FreeBSD that is not using ports, for sure, using current 
gentoo's ebuilds for autotooled Xorg.
Comment 5 Adam Jackson 2005-09-10 22:16:08 UTC 
i would like to see some indication that these fixes are necessary for stock
freebsd systems too.  if only portage users need them on freebsd, that would
indicate a bug in portage, not in X.
Comment 6 Diego Elio Pettenò 2005-09-12 16:26:21 UTC 
This seems tied to bug #4078, have to try with a newer snapshot where that is 
fixed, and this *should* be fixed, too. 
 
[And no, the problem was not portage then]
Comment 7 Diego Elio Pettenò 2005-09-13 00:15:18 UTC 
As said, fix to #4078 fixes this, too. It was a missing define in the new 
build system with a lot of hidden black magic. 
 

*** This bug has been marked as a duplicate of 4078 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.