Bug 4078 - hw/xfree86/common/xf86KbdBSD.c: xf86Info.consType is conditioned to CSRG_BASED
Summary: hw/xfree86/common/xf86KbdBSD.c: xf86Info.consType is conditioned to CSRG_BASED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: Other FreeBSD
: high normal
Assignee: Xorg Project Team
QA Contact:
: 4075 4077 (view as bug list)
Depends on:
Blocks: 4429
  Show dependency treegraph
Reported: 2005-08-14 08:45 UTC by Diego Elio Pettenò
Modified: 2005-09-12 07:15 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

xorg-server-hw-xfree86-common-xf86KbdBSD.patch (284 bytes, patch)
2005-08-17 09:43 UTC, Diego Elio Pettenò
no flags Details | Splinter Review

Description Diego Elio Pettenò 2005-08-14 08:45:50 UTC
On xf86Privstr.h, xf86Info.consType is conditioned to CSRG_BASED define, while  
it's used on the file in summary on ! __bsdi__ define and fails to compile. 
The attached patch changes the condition on xf86KbdBSD.c to match the one in 
Comment 1 Diego Elio Pettenò 2005-08-14 08:46:20 UTC
Created attachment 3346 [details] [review]
proposed patch of Xt4/tstlnggprc.m
Comment 2 Diego Elio Pettenò 2005-08-17 09:43:47 UTC
Created attachment 2908 [details] [review]

Re-attached deleted patch
Comment 3 Alan Coopersmith 2005-08-19 16:58:48 UTC
xf86KbdBSD.c should only be built on CSRG_BASED systems though, so I think the
real problem is getting either CSRG_BASED defined for BSD's in the modular build
or replacing all the uses of it with more specific checks.
Comment 4 Matthieu Herrb 2005-08-21 08:34:26 UTC
As discussed  on the modular list some time ago, I commited a change that
defines CSRG_BASED in Xosdefs.h for the modular tree. 
Comment 5 Diego Elio Pettenò 2005-09-13 00:03:08 UTC
Trying with a recent snapshot and defining by hand -DCSRG_BASED (as x11proto 
is still outdated) seems to fix that as well as a couple more bugs. 
Comment 6 Diego Elio Pettenò 2005-09-13 00:03:33 UTC
*** Bug 4075 has been marked as a duplicate of this bug. ***
Comment 7 Diego Elio Pettenò 2005-09-13 00:15:18 UTC
*** Bug 4077 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.