|Summary:||test-corrupt has undeclared dependency on GLib 2.26 and leaks refs|
|Product:||dbus||Reporter:||Simon McVittie <smcv>|
|Component:||core||Assignee:||Simon McVittie <smcv>|
|Status:||RESOLVED FIXED||QA Contact:||John (J5) Palmieri <johnp>|
|i915 platform:||i915 features:|
|Bug Depends on:|
|Attachments:||corrupt test: compile successfully against older GLib (Debian stable)|
Description Simon McVittie 2011-09-26 03:33:59 UTC
We could bump the dependency in configure.ac to 2.26, but that breaks compilation on (for instance) Debian stable, and we don't really need g_socket_send_with_blocking here anyway. Also, don't leak the GLib socket objects.
Comment 1 Simon McVittie 2011-09-26 10:14:24 UTC
Created attachment 51639 [details] [review] corrupt test: compile successfully against older GLib (Debian stable) We don't really need g_socket_send_with_blocking here. Also, don't leak the GLib socket objects.
Comment 2 Lennart Poettering 2011-11-01 09:14:33 UTC
Uh, really evil, but given that this is a just a test looks good and does the job.
Comment 3 Simon McVittie 2011-11-02 10:04:28 UTC
Thanks, fixed in git for 1.4.18, 1.5.10