| Summary: | test-corrupt has undeclared dependency on GLib 2.26 and leaks refs | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Simon McVittie <smcv> |
| Component: | core | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | John (J5) Palmieri <johnp> |
| Severity: | normal | ||
| Priority: | medium | CC: | hp |
| Version: | 1.4.x | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.freedesktop.org/~smcv/dbus/log/?h=14-older-glib-41219 | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 36074 | ||
| Attachments: | corrupt test: compile successfully against older GLib (Debian stable) | ||
Created attachment 51639 [details] [review] corrupt test: compile successfully against older GLib (Debian stable) We don't really need g_socket_send_with_blocking here. Also, don't leak the GLib socket objects. Uh, really evil, but given that this is a just a test looks good and does the job. Thanks, fixed in git for 1.4.18, 1.5.10 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
We could bump the dependency in configure.ac to 2.26, but that breaks compilation on (for instance) Debian stable, and we don't really need g_socket_send_with_blocking here anyway. Also, don't leak the GLib socket objects.