Bug 41257

Summary:	Tests should use inttypes.h if stdint.h is not available
Product:	pixman	Reporter:	Dagobert Michelsen <dam>
Component:	pixman	Assignee:	Søren Sandmann Pedersen <soren.sandmann>
Status:	RESOLVED FIXED	QA Contact:	Søren Sandmann Pedersen <soren.sandmann>
Severity:	normal
Priority:	medium
Version:	other
Hardware:	SPARC
OS:	Solaris
Whiteboard:
i915 platform:		i915 features:
Attachments:	Use inttypes.h when stdint.h is not available

Description Dagobert Michelsen 2011-09-27 07:08:53 UTC

Created attachment 51660 [details] [review]
Use inttypes.h when stdint.h is not available

The testsuite should use inttypes.h if stdint.h is not available as for example on Solaris 9. The presence of both headers is already detected during configure time. The attached patch fixes the issue by shielding the include with the proper definitions.

Comment 1 Dagobert Michelsen 2011-09-27 07:09:26 UTC

This patch is against 0.22.2 (which is available in the version selection box).

Comment 2 Søren Sandmann Pedersen 2011-09-27 08:33:45 UTC

Thanks for the bug report. 

The lowlevel-blt issue is already fixed in master. I've sent a proposed fix here:

    http://lists.freedesktop.org/archives/pixman/2011-September/001558.html

We don't actually need to include stdint.h.

Comment 3 Dagobert Michelsen 2011-09-27 08:36:57 UTC

Your proposed fix is only for test/scaling-helpers-test.c
It needs also be fixed in test/lowlevel-blt-bench.c

Comment 4 Søren Sandmann Pedersen 2011-09-27 10:21:06 UTC

Yes, but lowlevel-blt-bench.c is already fixed in master.

Comment 5 Dagobert Michelsen 2011-09-28 00:35:42 UTC

Sounds good. Thanks for fixing!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.