41257 – Tests should use inttypes.h if stdint.h is not available

Bug 41257 - Tests should use inttypes.h if stdint.h is not available

Summary: Tests should use inttypes.h if stdint.h is not available

Status:	RESOLVED FIXED

Alias:	None

Product:	pixman
Classification:	Unclassified
Component:	pixman (show other bugs)
Version:	other
Hardware:	SPARC Solaris

Importance:	medium normal
Assignee:	Søren Sandmann Pedersen
QA Contact:	Søren Sandmann Pedersen

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-09-27 07:08 UTC by Dagobert Michelsen
Modified:	2011-09-29 02:03 UTC (History)
CC List:	0 users

See Also:
i915 platform:
i915 features:

Attachments
Use inttypes.h when stdint.h is not available (1.19 KB, patch) 2011-09-27 07:08 UTC, Dagobert Michelsen	Details \| Splinter Review
View All

Description Dagobert Michelsen 2011-09-27 07:08:53 UTC

Created attachment 51660 [details] [review]
Use inttypes.h when stdint.h is not available

The testsuite should use inttypes.h if stdint.h is not available as for example on Solaris 9. The presence of both headers is already detected during configure time. The attached patch fixes the issue by shielding the include with the proper definitions.

Comment 1 Dagobert Michelsen 2011-09-27 07:09:26 UTC

This patch is against 0.22.2 (which is available in the version selection box).

Comment 2 Søren Sandmann Pedersen 2011-09-27 08:33:45 UTC

Thanks for the bug report. 

The lowlevel-blt issue is already fixed in master. I've sent a proposed fix here:

    http://lists.freedesktop.org/archives/pixman/2011-September/001558.html

We don't actually need to include stdint.h.

Comment 3 Dagobert Michelsen 2011-09-27 08:36:57 UTC

Your proposed fix is only for test/scaling-helpers-test.c
It needs also be fixed in test/lowlevel-blt-bench.c

Comment 4 Søren Sandmann Pedersen 2011-09-27 10:21:06 UTC

Yes, but lowlevel-blt-bench.c is already fixed in master.

Comment 5 Dagobert Michelsen 2011-09-28 00:35:42 UTC

Sounds good. Thanks for fixing!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.