Bug 41364

Summary: parse_message_body inexplicably parses a string it just built.
Product: Ytstenut Reporter: Will Thompson <will>
Component: pluginsAssignee: Jonny Lamb <jonny.lamb>
Status: NEW --- QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: parse_message_body: clean up empty body special case

Description Will Thompson 2011-09-30 08:40:04 UTC
static WockyNodeTree *
parse_message_body (const gchar *body,
    GError **error)
{
  // … snip snip …
  if (body == NULL || *body == '\0')
    body = "<ytstenut:message xmlns:ytstenut=\"" YTST_MESSAGE_NS "\" />";

and then we go on to parse that message back out.

Buh?
Comment 1 Will Thompson 2011-09-30 08:40:22 UTC
Created attachment 51799 [details] [review]
parse_message_body: clean up empty body special case
Comment 2 Will Thompson 2011-09-30 08:40:37 UTC
I haven't tested my patch, I should admit.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.