Bug 41364 - parse_message_body inexplicably parses a string it just built.
Summary: parse_message_body inexplicably parses a string it just built.
Status: NEW
Alias: None
Product: Ytstenut
Classification: Unclassified
Component: plugins (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Jonny Lamb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-30 08:40 UTC by Will Thompson
Modified: 2011-09-30 08:40 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
parse_message_body: clean up empty body special case (1.56 KB, patch)
2011-09-30 08:40 UTC, Will Thompson 		Details | Splinter Review
View All

Description Will Thompson 2011-09-30 08:40:04 UTC 
static WockyNodeTree *
parse_message_body (const gchar *body,
    GError **error)
{
  // … snip snip …
  if (body == NULL || *body == '\0')
    body = "<ytstenut:message xmlns:ytstenut=\"" YTST_MESSAGE_NS "\" />";

and then we go on to parse that message back out.

Buh?
Comment 1 Will Thompson 2011-09-30 08:40:22 UTC 
Created attachment 51799 [details] [review]
parse_message_body: clean up empty body special case
Comment 2 Will Thompson 2011-09-30 08:40:37 UTC 
I haven't tested my patch, I should admit.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.