Bug 41537

Summary:	Fix to make esdcompat more portable
Product:	PulseAudio	Reporter:	Brian Cameron <brian.cameron>
Component:	daemon	Assignee:	pulseaudio-bugs
Status:	RESOLVED MOVED	QA Contact:	pulseaudio-bugs
Severity:	normal
Priority:	medium	CC:	lennart
Version:	unspecified
Hardware:	Other
OS:	Solaris
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch fixing issue

Description Brian Cameron 2011-10-06 14:18:29 UTC

Created attachment 52058 [details] [review]
patch fixing issue

The src/daemon/esdcompat.in file could be updated with the attached patch to make it work better with bourne shell.  Could this go upstream?

Comment 1 Tanu Kaskinen 2011-10-07 15:16:35 UTC

Isn't [ $1 ] an incorrect test? What if one of the parameters is an empty string - that evaluates to false then, doesn't it?  I think [ "$#" -gt "0" ] (the same as in the while condition) would be better.

Comment 2 Brian Cameron 2011-10-10 08:34:52 UTC

Agreed.  If it were possible to update this script to make the check better as you suggest, then it would work better with /bin/sh.

Comment 3 GitLab Migration User 2018-07-30 09:59:53 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/159.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.