Bug 41537 - Fix to make esdcompat more portable
Summary: Fix to make esdcompat more portable
Status: RESOLVED MOVED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: daemon (show other bugs)
Version: unspecified
Hardware: Other Solaris
: medium normal
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-06 14:18 UTC by Brian Cameron
Modified: 2018-07-30 09:59 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
patch fixing issue (490 bytes, patch)
2011-10-06 14:18 UTC, Brian Cameron
Details | Splinter Review

Description Brian Cameron 2011-10-06 14:18:29 UTC
Created attachment 52058 [details] [review]
patch fixing issue

The src/daemon/esdcompat.in file could be updated with the attached patch to make it work better with bourne shell.  Could this go upstream?
Comment 1 Tanu Kaskinen 2011-10-07 15:16:35 UTC
Isn't [ $1 ] an incorrect test? What if one of the parameters is an empty string - that evaluates to false then, doesn't it?  I think [ "$#" -gt "0" ] (the same as in the while condition) would be better.
Comment 2 Brian Cameron 2011-10-10 08:34:52 UTC
Agreed.  If it were possible to update this script to make the check better as you suggest, then it would work better with /bin/sh.
Comment 3 GitLab Migration User 2018-07-30 09:59:53 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/159.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.