Created attachment 52058 [details] [review] patch fixing issue The src/daemon/esdcompat.in file could be updated with the attached patch to make it work better with bourne shell. Could this go upstream?
Isn't [ $1 ] an incorrect test? What if one of the parameters is an empty string - that evaluates to false then, doesn't it? I think [ "$#" -gt "0" ] (the same as in the while condition) would be better.
Agreed. If it were possible to update this script to make the check better as you suggest, then it would work better with /bin/sh.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/159.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.