Bug 41969

Summary: The Mesa meta save/restore code doesn't always save the active program
Product: Mesa Reporter: Neil Roberts <nroberts>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: meta: Fix saving the active program

Description Neil Roberts 2011-10-18 10:50:01 UTC
Looks like there is a cut and paste error which means the meta save/restore code won't save the active program if it doesn't have a fragment shader. Please see the patch.
Comment 1 Neil Roberts 2011-10-18 10:52:06 UTC
Created attachment 52487 [details] [review]
meta: Fix saving the active program

When saving the active program in _mesa_meta_begin, it was actually
saving the fragment program instead. This means that if the
application binds a program that only has a vertex shader then when
the meta saved state is restored it will forget the bound program.
Comment 2 Chad Versace 2011-10-18 11:14:18 UTC
Thanks Neil. I've pushed the patch and am marking the bug as RESOLVED/FIXED.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.