Bug 41969 - The Mesa meta save/restore code doesn't always save the active program
Summary: The Mesa meta save/restore code doesn't always save the active program
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-18 10:50 UTC by Neil Roberts
Modified: 2011-10-18 11:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
meta: Fix saving the active program (1.16 KB, patch)
2011-10-18 10:52 UTC, Neil Roberts 		Details | Splinter Review
View All

Description Neil Roberts 2011-10-18 10:50:01 UTC 
Looks like there is a cut and paste error which means the meta save/restore code won't save the active program if it doesn't have a fragment shader. Please see the patch.
Comment 1 Neil Roberts 2011-10-18 10:52:06 UTC 
Created attachment 52487 [details] [review]
meta: Fix saving the active program

When saving the active program in _mesa_meta_begin, it was actually
saving the fragment program instead. This means that if the
application binds a program that only has a vertex shader then when
the meta saved state is restored it will forget the bound program.
Comment 2 Chad Versace 2011-10-18 11:14:18 UTC 
Thanks Neil. I've pushed the patch and am marking the bug as RESOLVED/FIXED.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.