| Summary: | base-contact-list doesn't implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 41801 | ||
| Attachments: |
base-contact-list: implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED
base-contact-list: implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED |
||
|
Description
Guillaume Desmottes
2011-10-20 06:04:19 UTC
Created attachment 52579 [details] [review] base-contact-list: implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED Comment on attachment 52579 [details] [review] base-contact-list: implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED Review of attachment 52579 [details] [review]: ----------------------------------------------------------------- Looks reasonable except for a copy-paste error. ::: telepathy-glib/base-contact-list.c @@ +6139,5 @@ > tp_base_contact_list_fill_groups_contact_attributes); > } > + > + if (g_type_is_a (type, TP_TYPE_SVC_CONNECTION_INTERFACE_CONTACT_BLOCKING) > + && TP_IS_CONTACT_GROUP_LIST (self)) Why TP_IS_CONTACT_GROUP_LIST? I don't think blocking should depend on groups. Created attachment 52580 [details] [review] base-contact-list: implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED Merged; will be in 0.16.1 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.