Bug 42049 - base-contact-list doesn't implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED
Summary: base-contact-list doesn't implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLO...
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 41801
  Show dependency tree / graph
 
Reported: 2011-10-20 06:04 UTC by Guillaume Desmottes
Modified: 2011-10-24 03:34 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
base-contact-list: implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED (4.48 KB, patch)
2011-10-20 06:07 UTC, Guillaume Desmottes 		Details | Splinter Review
base-contact-list: implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED (4.48 KB, patch)
2011-10-20 06:13 UTC, Guillaume Desmottes 		Details | Splinter Review
Show Obsolete (1) View All

Comment 1 Guillaume Desmottes 2011-10-20 06:07:21 UTC 
Created attachment 52579 [details] [review]
base-contact-list: implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED
Comment 2 Will Thompson 2011-10-20 06:12:20 UTC 
Comment on attachment 52579 [details] [review]
base-contact-list: implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED

Review of attachment 52579 [details] [review]:
-----------------------------------------------------------------

Looks reasonable except for a copy-paste error.

::: telepathy-glib/base-contact-list.c
@@ +6139,5 @@
>            tp_base_contact_list_fill_groups_contact_attributes);
>      }
> +
> +  if (g_type_is_a (type, TP_TYPE_SVC_CONNECTION_INTERFACE_CONTACT_BLOCKING)
> +      && TP_IS_CONTACT_GROUP_LIST (self))

Why TP_IS_CONTACT_GROUP_LIST? I don't think blocking should depend on groups.
Comment 3 Guillaume Desmottes 2011-10-20 06:13:21 UTC 
Created attachment 52580 [details] [review]
base-contact-list: implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED
Comment 4 Guillaume Desmottes 2011-10-24 03:34:18 UTC 
Merged; will be in 0.16.1

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.