Bug 42578

Created attachment 53258 [details] [review]
wip patch

I think I need to punt this off to Jesse. I have no idea what some of the old fields mean, and I can't even find definitions for some of the new fields he added on the other related debugfs entry.

I just posted some patches on intel-gfx for a fix. The WIP patch is actually not correct as it doesn't attempt to unforcewake before reading.

A patch referencing this bug report has been merged in Linux v3.3-rc1:

commit 4d85529d584856d077895a2daa703224d3aee7e1
Author: Ben Widawsky <ben@bwidawsk.net>
Date:   Mon Dec 12 19:34:16 2011 -0800

    drm/i915: drpc debugfs update for gen6

This issue has been fixed.
cat /sys/kernel/debug/dri/0/ i915_drpc_info with the latest kernel, info listed below.
RC information accurate: yes
Video Turbo Mode: yes
HW control enabled: yes
SW control enabled: no
RC6 Enabled: no
RC6 Enabled: yes
Deep RC6 Enabled: yes
Deepest RC6 Enabled: no
Current RC state: RC6
Core Power Down: no

there are two RC6 status"RC6 Enabled: no" and "RC6 Enabled: yes". I am confused it.
checking codes,fuction gen6_drpc_info in drm-intel/drivers/gpu/drm/i915/i915_debugfs.c:
seq_printf(m, "RC6 Enabled: %s\n",
                   yesno(rcctl1 & GEN6_RC_CTL_RC1e_ENABLE));
seq_printf(m, "RC6 Enabled: %s\n",
                   yesno(rcctl1 & GEN6_RC_CTL_RC6_ENABLE));

reading GEN6_RC_CTL_RC1e_ENABLE and GEN6_RC_CTL_RC6_ENABLE,output "RC6 Enabled: no" and "RC6 Enabled: yes". what's the current RC6 status?

(In reply to comment #3)
> A patch referencing this bug report has been merged in Linux v3.3-rc1:
> commit 4d85529d584856d077895a2daa703224d3aee7e1
> Author: Ben Widawsky <ben@bwidawsk.net>
> Date:   Mon Dec 12 19:34:16 2011 -0800
>     drm/i915: drpc debugfs update for gen6

This was (In reply to comment #4)
> This issue has been fixed.
> cat /sys/kernel/debug/dri/0/ i915_drpc_info with the latest kernel, info listed
> below.
> RC information accurate: yes
> Video Turbo Mode: yes
> HW control enabled: yes
> SW control enabled: no
> RC6 Enabled: no
> RC6 Enabled: yes
> Deep RC6 Enabled: yes
> Deepest RC6 Enabled: no
> Current RC state: RC6
> Core Power Down: no
> 
> there are two RC6 status"RC6 Enabled: no" and "RC6 Enabled: yes". I am confused
> it.
> checking codes,fuction gen6_drpc_info in
> drm-intel/drivers/gpu/drm/i915/i915_debugfs.c:
> seq_printf(m, "RC6 Enabled: %s\n",
>                    yesno(rcctl1 & GEN6_RC_CTL_RC1e_ENABLE));
> seq_printf(m, "RC6 Enabled: %s\n",
>                    yesno(rcctl1 & GEN6_RC_CTL_RC6_ENABLE));
> 
> reading GEN6_RC_CTL_RC1e_ENABLE and GEN6_RC_CTL_RC6_ENABLE,output "RC6 Enabled:
> no" and "RC6 Enabled: yes". what's the current RC6 status?
> 
> (In reply to comment #3)
> > A patch referencing this bug report has been merged in Linux v3.3-rc1:
> > commit 4d85529d584856d077895a2daa703224d3aee7e1
> > Author: Ben Widawsky <ben@bwidawsk.net>
> > Date:   Mon Dec 12 19:34:16 2011 -0800
> >     drm/i915: drpc debugfs update for gen6

There was a bug in the patch which Eric Anholt has fixed. It should already be in Keith's tree. I am closing this bug.