Bug 42761

Summary: GMail qirks fail if the GMail user is invisible
Product: Telepathy Reporter: Olivier Crête <olivier.crete>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED MOVED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: git master   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: patch to not use quirks for video_rtp/rtcp

Description Olivier Crête 2011-11-09 14:16:27 UTC 
Created attachment 53350 [details] [review]
patch to not use quirks for video_rtp/rtcp

If the GMail user is invisible, we don't get its presence, we can't know it's using gmail. The quirks fail.

This prevents video calls from working as it doesnt know to use "video_rtp" as the "name" attribute instead of rtp.

I think we should just forget about the quirks and try to be clever and do something that always works.

For example, for calls, if it's the Google transport, we can just always accept video_rtp,video_rtcp as synomyms of rtp/rtcp. And for the outgoing candidates, we can just send both (ie, duplicate every video candidate). The attached patch does exactly that and makes incoming video calls from GMail users work.
Comment 1 Will Thompson 2011-11-10 07:30:40 UTC 
Hmm, if this still works with old Gabble, then ship it (presumably to 0.14 and master and maybe 0.12 if you're feeling keen)?
Comment 2 GitLab Migration User 2019-12-03 19:54:27 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/189.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.