Bug 42761 - GMail qirks fail if the GMail user is invisible
Summary: GMail qirks fail if the GMail user is invisible
Status: NEW
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-09 14:16 UTC by Olivier Crête
Modified: 2011-11-10 07:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch to not use quirks for video_rtp/rtcp (2.86 KB, patch)
2011-11-09 14:16 UTC, Olivier Crête
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Crête 2011-11-09 14:16:27 UTC
Created attachment 53350 [details] [review]
patch to not use quirks for video_rtp/rtcp

If the GMail user is invisible, we don't get its presence, we can't know it's using gmail. The quirks fail.

This prevents video calls from working as it doesnt know to use "video_rtp" as the "name" attribute instead of rtp.

I think we should just forget about the quirks and try to be clever and do something that always works.

For example, for calls, if it's the Google transport, we can just always accept video_rtp,video_rtcp as synomyms of rtp/rtcp. And for the outgoing candidates, we can just send both (ie, duplicate every video candidate). The attached patch does exactly that and makes incoming video calls from GMail users work.
Comment 1 Will Thompson 2011-11-10 07:30:40 UTC
Hmm, if this still works with old Gabble, then ship it (presumably to 0.14 and master and maybe 0.12 if you're feeling keen)?


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.