Bug 43602

Summary: SetFontPath incorrectly encodes path
Product: XCB Reporter: Robert Ancell <robert.ancell>
Component: ProtocolAssignee: xcb mailing list dummy <xcb>
Status: RESOLVED FIXED QA Contact: xcb mailing list dummy <xcb>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Robert Ancell 2011-12-07 15:04:50 UTC
SetFontPath doesn't encode the path strings correctly - it should be the same as the GetFontPath reply:

--- a/src/xproto.xml
+++ b/src/xproto.xml
@@ -1481,8 +1481,11 @@ authorization from the authors.
 
   <request name="SetFontPath" opcode="51">
     <pad bytes="1" />
-    <field type="CARD16" name="font_qty" />
-    <list type="char" name="path" />
+    <field type="CARD16" name="path_len" />
+    <pad bytes="2" />
+    <list type="STR" name="path">
+      <fieldref>path_len</fieldref>
+    </list>
   </request>
 
   <request name="GetFontPath" opcode="52">
Comment 1 Julien Danjou 2012-01-11 08:07:38 UTC
Patch merged, without the API breaking change.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.