Bug 43602 - SetFontPath incorrectly encodes path
Summary: SetFontPath incorrectly encodes path
Status: RESOLVED FIXED
Alias: None
Product: XCB
Classification: Unclassified
Component: Protocol (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xcb mailing list dummy
QA Contact: xcb mailing list dummy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-07 15:04 UTC by Robert Ancell
Modified: 2012-01-11 08:07 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Robert Ancell 2011-12-07 15:04:50 UTC
SetFontPath doesn't encode the path strings correctly - it should be the same as the GetFontPath reply:

--- a/src/xproto.xml
+++ b/src/xproto.xml
@@ -1481,8 +1481,11 @@ authorization from the authors.
 
   <request name="SetFontPath" opcode="51">
     <pad bytes="1" />
-    <field type="CARD16" name="font_qty" />
-    <list type="char" name="path" />
+    <field type="CARD16" name="path_len" />
+    <pad bytes="2" />
+    <list type="STR" name="path">
+      <fieldref>path_len</fieldref>
+    </list>
   </request>
 
   <request name="GetFontPath" opcode="52">
Comment 1 Julien Danjou 2012-01-11 08:07:38 UTC
Patch merged, without the API breaking change.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.