Summary: | Test tubes/offer-private-stream-tube.py failing in buildbot | ||
---|---|---|---|
Product: | Telepathy | Reporter: | Alvaro Soliverez <alvaro.soliverez> |
Component: | gabble | Assignee: | Simon McVittie <smcv> |
Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
Severity: | normal | ||
Priority: | medium | Keywords: | patch |
Version: | git master | ||
Hardware: | Other | ||
OS: | All | ||
URL: | http://cgit.freedesktop.org/~jonny/telepathy-gabble/commit/?h=43981-unix-path | ||
Whiteboard: | nearly review+ | ||
i915 platform: | i915 features: | ||
Attachments: | tubetestutil: clear list in a way that doesn't make it a local variable |
Description
Alvaro Soliverez
2011-12-20 07:16:02 UTC
This should make things work. Not sure about the cleanup thing. What do people think? (Obviously this goes on the assumption that a temp file isn't created in the biggest path evah.) r+ if you make _to_cleanup empty its list so it's idempotent? (In reply to comment #3) > r+ if you make _to_cleanup empty its list so it's idempotent? Good point. Done and dusted^Wpushed. Created attachment 56368 [details] [review] tubetestutil: clear list in a way that doesn't make it a local variable (In reply to comment #4) > Good point. Done and dusted^Wpushed. Turns out not to work, see attached. (In reply to comment #5) > Turns out not to work, see attached. Yes yes, I suck. Sorry. :-( r+ |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.